Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix(updating): use PUT not PATCH when updating an existing Secret #20

Merged
merged 1 commit into from
Feb 20, 2019
Merged

fix(updating): use PUT not PATCH when updating an existing Secret #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/poller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class Poller {
}

this._logger.info(`updating secret ${secretName}`);
return kubeNamespace.secrets(secretName).patch({ body: secretManifest });
return kubeNamespace.secrets(secretName).put({ body: secretManifest });
}

/**
Expand Down
4 changes: 2 additions & 2 deletions lib/poller.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ describe('Poller', () => {

it('updates secret', async () => {
kubeNamespaceMock.get = sinon.stub().resolves({ fakeSecretName: 'fakeSecretString' });
kubeNamespaceMock.patch = sinon.stub().resolves();
kubeNamespaceMock.put = sinon.stub().resolves();

await poller._upsertKubernetesSecret(upsertSecretParams);

expect(kubeNamespaceMock.secrets.calledWith('fakeSecretName')).to.be.true;
expect(kubeNamespaceMock.get.called).to.be.true;
expect(kubeNamespaceMock.patch.calledWith({
expect(kubeNamespaceMock.put.calledWith({
body: {
apiVersion: 'v1',
kind: 'Secret',
Expand Down