Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plug-ins: dailymotion_a, twitch_a, youtube_a #956

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

GrosPoulet
Copy link
Collaborator

These plug-ins were modified so they can benefit from the new headers rewrite feature.

These plug-ins were modified so they can benefit from the new headers rewrite feature.
@gitguardian
Copy link

gitguardian bot commented Jun 16, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 98403d9 plugins/youtube_a.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@GrosPoulet GrosPoulet merged commit 8f2b25a into extesy:master Jun 16, 2022
@extesy
Copy link
Owner

extesy commented Jun 16, 2022

Have you tested youtube changes on https://www.reddit.com/r/videos/? It feels like fewer videos are playing now than before. I think it might be because of the change in how the size is selected. For example https://old.reddit.com/r/videos/comments/vd8s09/how_to_make_chili_for_one/ doesn't have any 720p sizes. Previously the largest alternative would be selected. With your change, nothing gets played at all.

@extesy
Copy link
Owner

extesy commented Jun 16, 2022

Also there are url patterns with start time like https://www.reddit.com/r/videos/comments/vdg6f7/beastie_boys_intergalactic/ which has &t=28 but I've seen others like &t=1h2m3s. Seems like your algorithm drops them now. This is what it used to do:

link.data().hoverZoomSrc = [start ? src.url + '#t=' + start : src.url]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants