Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filesystem access example plugin #25

Closed
wants to merge 1 commit into from
Closed

Adds filesystem access example plugin #25

wants to merge 1 commit into from

Conversation

JayJamieson
Copy link

Adding example plugin showing writing files to disk. Moved here from feedback in this PR

Do I need to update readme as well explaining usage?

@nilslice
Copy link
Member

@JayJamieson thank you for this! maybe before we merge, it might be good to see how #26 helps this.. if we can instead use the documentation about this new package which should ease the usage of a reactor Go wasm module, then we may not need to have such specific instructions.

Could you test the new package in your module, and if it helps, rebase this branch off #26 (assuming its in main by then) and update the docs to what you think is best?

@JayJamieson
Copy link
Author

Ah actually, this PR is not needed then sorry. I'll close since #26 better covers what my intention was. Thank you for taking the time to reply.

Thank you @mhmd-azeez for a much nicer implementation <3

@JayJamieson JayJamieson deleted the feat/add-fs-example-plugin branch January 19, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants