Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent log allocation unless needed #46

Closed
wants to merge 1 commit into from
Closed

Conversation

nilslice
Copy link
Member

@nilslice nilslice commented Aug 27, 2024

Is blocked by:

TODO:

  • add "off" case e.g.
if level == tracing::level_filters::LevelFilter::OFF {
        output[0] = Val::I32(i32::MAX)
...

Expect CI to fail as this PR includes new (unreleased) runtime functions

@nilslice
Copy link
Member Author

("off" case is already handled via max int32 being impossible to exceed by user-set log level)

@zshipko
Copy link
Contributor

zshipko commented Oct 24, 2024

Oops, I forgot there was already a PR for this. Closing because it's done in #48

@zshipko zshipko closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants