Prep for TinyGo's v0.28 encoding/json Support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @syke99! we just updated our CI for this repo to use the latest tinygo, so we'll take a look at this and get back to you asap. |
nilslice
requested changes
Oct 8, 2023
extism_pdk.go
Outdated
| type HTTPRequestMeta struct { | ||
| Url string `json:"url"` | ||
| Method string `json:"method"` | ||
| Headers map[string]string `json:"header"` |
There was a problem hiding this comment.
technically we support this json field name in the Rust runtime, but for consistency and long-term support I think we should change the JSON struct tag to headers here.
There was a problem hiding this comment.
whoops, yeah. was a copy paste error lol. one sec
wikiwong
approved these changes
Oct 8, 2023
|
Great update, thanks @syke99 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the fastjson dependency in favor of using the stdlib's encoding/json package as it will be fully supported by TinyGo's v0.28 release