feat,fix: respect EXTISM_ENABLE_WASI_OUTPUT #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
reviewed
Jan 5, 2024
nilslice
reviewed
Jan 5, 2024
I implemented this as an `ExtismPluginOption`, `enableWasiOutput`, that defaults to checking the environment variable (on platforms that support runtime environment variables.) - There was a WASI browser polyfill bug with the wasistdout module. Since `wasistdout` doesn't export a `initialize` or `start` method, we weren't initializing the context appropriately. This now fixed. - Neither Deno nor Node squelched WASI output before this commit. Now they do by default -- by opening /dev/null (or NUL on Windows) and sending that FD in instead. - And now the browser supports WASI output as well! - Additionally, simplify all `prop?: T | undefined` to `prop?: T` in `src/interfaces.ts`. Fixes #43.
chrisdickinson
force-pushed
the
chris/20240104-respect-extism-output-env-var
branch
from
8036bc8
to
3d4164c
Compare
chrisdickinson
deleted the
chris/20240104-respect-extism-output-env-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this as an
ExtismPluginOption,enableWasiOutput, that defaults to checking the environment variable (on platforms that support runtime environment variables.)wasistdoutdoesn't export ainitializeorstartmethod, we weren't initializing the context appropriately. This now fixed.Fixes #43.