-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update README #17
Conversation
Not sure why there were some build errors on my machine |
@mhmd-azeez - thank you! which version of Zig are you using with this? I'm on |
@nilslice seems like they have changed it to
|
Hah! it's been changed 3 weeks ago: ziglang/zig@3fc6fc6 |
This reverts commit 119acb0.
haha! thank you for looking at that. sorry I was behind a few versions... I think our strategy has been to follow the latest versions as close as possible. @usdogu can advise, as the expert Zig extism contributor! |
In addition to reviewing the API changes, please also take a close look at the examples to make sure allocations and deallocations are properly managed |
Thanks for taking this one on! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these, LGTM!
Co-authored-by: Doğu Us <73913444+usdogu@users.noreply.github.com>
@usdogu thank you very much for you suggestions! |
Also added the readme examples to |
Going to merge this one & make sure #19 works based on it |
allocate
,allocateBytes
,findMemory
toPlugin
. SinceMemory
is not public, there was no way to call themsetError
andsetErrorMemory
getVarInt
andsetVarInt
Fixes #16