Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open file in $EDITOR from tigui #166

Closed
alex-popov-tech opened this issue Jul 1, 2020 · 1 comment · Fixed by #173
Closed

open file in $EDITOR from tigui #166

alex-popov-tech opened this issue Jul 1, 2020 · 1 comment · Fixed by #173
Labels
enhancement New feature or request

Comments

@alex-popov-tech
Copy link

When you watching at diffs you sometimes may want to edit file just a bit, and for that in tig there is e key to open selected file in $EDITOR, would be super cool to have same functionality here as well
@extrawurst
Copy link
Owner

That is a good idea, I think this should be quite possible now that we have a use-case already where opening an external editor was added: #114

@extrawurst extrawurst added the enhancement New feature or request label Jul 1, 2020
jonstodle added a commit to jonstodle/gitui that referenced this issue Jul 6, 2020
@jonstodle
Add command to edit selected file in editor
ee6b381 
Pressing `e` while looking at a file in the _Status_ view will launch an external editor with the current file opened. The editor chosen is determined by the default logic introduced in extrawurst#114.

An improvement to this in the future could be launching at the specific line at which the _Diff_ view is focused, but that seems to require a change in `FileDiff` which is a change bigger than this PR.

Fixes extrawurst#166
@jonstodle jonstodle mentioned this issue Jul 6, 2020
Merged
jonstodle added a commit to jonstodle/gitui that referenced this issue Jul 6, 2020
@jonstodle
Add command to edit selected file in editor
d691d7a 
Pressing `e` while looking at a file in the _Status_ view will launch an external editor with the current file opened. The editor chosen is determined by the default logic introduced in extrawurst#114.

An improvement to this in the future could be launching at the specific line at which the _Diff_ view is focused, but that seems to require a change in `FileDiff` which is a change bigger than this PR.

Fixes extrawurst#166
extrawurst pushed a commit that referenced this issue Jul 7, 2020
@jonstodle
Add command to edit selected file in editor
52f31ad 
Pressing `e` while looking at a file in the _Status_ view will launch an external editor with the current file opened. The editor chosen is determined by the default logic introduced in #114.

An improvement to this in the future could be launching at the specific line at which the _Diff_ view is focused, but that seems to require a change in `FileDiff` which is a change bigger than this PR.

Fixes #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add command to edit selected file in editor jonstodle/gitui
2 participants
@extrawurst @alex-popov-tech