Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow aborting search #1860

Closed
extrawurst opened this issue Aug 30, 2023 · 3 comments · Fixed by #2078
Closed

allow aborting search #1860

extrawurst opened this issue Aug 30, 2023 · 3 comments · Fixed by #2078
Labels
feature-request
Milestone
v0.25

Comments

@extrawurst
Copy link
Owner

especially searching in the filenames of commits can take very long and can be annoying to have to kill gitui to abort
@extrawurst extrawurst added this to the v0.25 milestone Aug 30, 2023
@StemCll
Copy link
Contributor

StemCll commented Jan 3, 2024

Hi @extrawurst 👋
I'm planning to take on this issue. Do you have any more details how to test this (maybe you have a certain repository to iterate over and search for "things"), what strategy should be undertaken when aborting etc.?

@StemCll StemCll mentioned this issue Jan 7, 2024
Closed
4 tasks
@StemCll
Copy link
Contributor

StemCll commented Jan 7, 2024

Hi @extrawurst
I've pushed changes and created a PR. I haven't updated changelog yet - waiting for your CR 😄

@extrawurst extrawurst mentioned this issue Feb 20, 2024
Merged
extrawurst added a commit that referenced this issue Feb 20, 2024
@extrawurst @StemCll
cancel commit search (#2078)
5dad9f4 
closes #1860

Co-authored-by: StemCll <lydjotj6f@mozmail.com>
@extrawurst
Copy link
Owner Author

@StemCll thanks for the groundwork you layed

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
@extrawurst @StemCll @IndianBoy42
cancel commit search (extrawurst#2078)
9ce0d51 
closes extrawurst#1860

Co-authored-by: StemCll <lydjotj6f@mozmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
v0.25
Development

Successfully merging a pull request may close this issue.

cancel commit search extrawurst/gitui
feat(LogSearch): Allow aborting search StemCll/gitui
2 participants
@extrawurst @StemCll