Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to Files from Details -> Inspect or Diff is not working #2114

Closed
VasilisManol opened this issue Mar 6, 2024 · 3 comments · Fixed by #2141
Closed

Going to Files from Details -> Inspect or Diff is not working #2114

VasilisManol opened this issue Mar 6, 2024 · 3 comments · Fixed by #2141
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@VasilisManol
Copy link

Describe the bug
Going to Files Tab from Details or Diff view in Log is failing

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Log' Tab.
  2. Select a commit from history and press 'Enter' to go to Details and then 'Right' Inspect.
  3. The option to go to Files with F is presented.
  4. Pressing 'F' has no effect.
  5. Selecting a file and pressing 'Right' again to diff will have the same issue. Files option is presented but nothing happens.

Expected behavior
I expected to go to Files Tab showing the selected file and the commit revision inspecting.

Context (please complete the following information):

  • Ubuntu 23.10
  • GitUI 0.25.1

Additional context
Otherwise Files tab works as expected. Tested on Alacritty and Foot.

@VasilisManol VasilisManol added the bug Something isn't working label Mar 6, 2024
@extrawurst extrawurst added the good first issue Good for newcomers label Mar 6, 2024
@extrawurst
Copy link
Owner

I suspect that this is just commands showing up in the cmd bar that are unavailable in these circumstances

@VasilisManol
Copy link
Author

I haven't checked. It would be a cool feature though to have them available. Like you are checking a specific commit in the log tab and then you jump to files to inspect a changed file at that commit.

@martihomssoler
Copy link
Contributor

Hey, as per discussed in the discord server. I found the commit that removed the functionality ( 7dcf93e ). I will fix it and get back to you with a proper PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants