New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 2114. Going to Files from Details -> Inspect or Diff is not working #2141

Merged

extrawurst merged 1 commit into extrawurst:master from martihomssoler:2114-go-to-files-from-commit

Mar 22, 2024

Contributor

martihomssoler commented Mar 20, 2024 •

edited by extrawurst

Loading

This Pull Request fixes/closes #2114.

The changes done are just reverting the deleted lines from 7dcf93e.

There was an idea to open a file at revision using a temp file. Let's discuss it further so I can add it to this PR.

It changes the following:

new event processed (open_file_tree) in InspectCommitPopup (while inspecting a commit)

I followed the checklist:

I added unittests
I ran make check without errors
I tested the overall application
I added an appropriate item to the changelog


          fix: 2114

99f22ea

Owner

extrawurst commented Mar 22, 2024

@martihomssoler thanks for your contribution. next time please add a changelog entry just like suggested in the checklist

extrawurst merged commit f40d368 into extrawurst:master

15 of 18 checks passed

martihomssoler deleted the 2114-go-to-files-from-commit branch

March 22, 2024 19:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet