Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit messages that begin with a hash (#) are ignored #2136

Closed
cleavera opened this issue Mar 19, 2024 · 2 comments · Fixed by #2145
Closed

Commit messages that begin with a hash (#) are ignored #2136

cleavera opened this issue Mar 19, 2024 · 2 comments · Fixed by #2145
Labels
bug Something isn't working feature-request good first issue Good for newcomers
Milestone

Comments

@cleavera
Copy link

cleavera commented Mar 19, 2024

Describe the bug
When using gitui to create a commit, commit messages that start with a # are ignored. This is the default behaviour of git however setting the config value core.commentChar makes the commit message work when using git on the command line, however commiting through gitui the commit message is still stripped out

To Reproduce
Steps to reproduce the behavior:

  1. Go to a project and make some changes
  2. Open git UI
  3. Commit the changes
  4. In the commit message dialog, use the message "#5123 test"
  5. Go to the log and the message for that commit is blank
  6. Make more changes
  7. Run `git config --global core.commentChar ";"``
  8. Repeat the above steps
  9. Same outcome

Expected behavior
The behaviour should match commiting with the command line, where changing the core.commentChar is respected

Screenshots
image
image
image

Context (please complete the following information):

  • OS/Distro + Version: Windows 11, 23h2, 22631.3296
  • GitUI Version: 0.24.3
  • Rust version: 1.75.0
@cleavera cleavera added the bug Something isn't working label Mar 19, 2024
@extrawurst
Copy link
Owner

should be fairly simple to implement: see 1a1c948

add commit_message_prettify into asyncgit and handle the config loading and forwarding of the configured comment-char

@extrawurst extrawurst modified the milestones: v0.25.2, v0.26 Mar 22, 2024
extrawurst pushed a commit that referenced this issue Mar 22, 2024
@cleavera
Copy link
Author

Thanks very much @extrawurst and @Concelare

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants