Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stashing support #3

Closed
extrawurst opened this issue Mar 22, 2020 · 9 comments
Closed

stashing support #3

extrawurst opened this issue Mar 22, 2020 · 9 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@extrawurst
Copy link
Owner

extrawurst commented Mar 22, 2020

some question need to be solved for this:

  • does the stashing happen in the status tab? or..
  • we will need a new tab for the stash list anyway, is that the place to also save stuff to the stash? this would allow setting the options like include untracked files?
  • if we stash in the status-tab, do we use a popup to ask for the options like that?
@extrawurst extrawurst added the enhancement New feature or request label Mar 30, 2020
@extrawurst extrawurst added the question Further information is requested label May 12, 2020
@extrawurst
Copy link
Owner Author

WIP at #70

extrawurst pushed a commit that referenced this issue May 18, 2020
extrawurst pushed a commit that referenced this issue May 19, 2020
@extrawurst
Copy link
Owner Author

extrawurst commented May 19, 2020

image

I think I am going for a two tab approach now

extrawurst pushed a commit that referenced this issue May 19, 2020
@extrawurst
Copy link
Owner Author

WIP
image

extrawurst pushed a commit that referenced this issue May 19, 2020
@extrawurst extrawurst mentioned this issue May 19, 2020
4 tasks
extrawurst pushed a commit that referenced this issue May 20, 2020
# Conflicts:
#	src/app.rs
extrawurst pushed a commit that referenced this issue May 21, 2020
# Conflicts:
#	src/app.rs
@jugglerchris
Copy link

This looks useful! One thing that would be useful that I don't see above is being able to stash individual lines or hunks rather than full files, like git stash push --patch (but with a better UI). I can raise this as a new feature request for later down the road (if you think it's a worthwhile enhancement, that is).

@extrawurst
Copy link
Owner Author

Yeah that's actually two feature requests. Stashing individual files was on my list (which we need the upstream lib to add support for first: libgit2/libgit2#4725), but stashing hunks actually never crossed my mind 🙈

@jugglerchris
Copy link

Thanks, I've raised a new feature request for stashing hunks.

@extrawurst
Copy link
Owner Author

finished: 63d3bf5

will go out in next release

@extrawurst
Copy link
Owner Author

stashing

@extrawurst
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants