Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tag support #483

Closed
extrawurst opened this issue Jan 11, 2021 · 8 comments · Fixed by #705
Closed

more tag support #483

extrawurst opened this issue Jan 11, 2021 · 8 comments · Fixed by #705
Milestone

Comments

@extrawurst
Copy link
Owner

extrawurst commented Jan 11, 2021

right, now I can only create a tag.

lets add a popup or tab (not sure yet) that allows:

  • list all tags (mark the ones not pushed to remote)
  • delete a tag
  • fetch tags
@ffes
Copy link

ffes commented Jan 14, 2021

You know about these settings?

fetch.prunetags=true
push.followtags=true

@WizardOhio24
Copy link
Contributor

Thinking a tab would be best for this, then could view associated commit details on the right (and perhaps press to go into the commit, like in the log tab). So it is like the log tab, but for tags, rather than commits.

@cruessler
Copy link
Contributor

@extrawurst I’d like to start working on this. I also think that introducing another tab seems like a good idea.

@extrawurst
Copy link
Owner Author

@cruessler take a go at it :)
I find a popup more fitting to be honest. similar to the branch list (list, rename, delete, ..) - in particular because I'd like quickly jump to the tag's commit in the log then. decoupling the tags-list and the log makes not much sense in my opinion.
what do you think?

@extrawurst extrawurst added this to the v0.16 milestone Apr 30, 2021
@WizardOhio24
Copy link
Contributor

Was going to mention, filtering by tag (so making a "tag-log") with :t is part of the search/filter functionality in #672 (continued from #506). So a popup might be better, but I'd question if it would even be necessary (after the search functionality is added, considering you can filter commits by/for tags). Perhaps just to jump to a commit with a specific tag? (or should that be implemented by holding down a key and pressing down/up to jump down/up tags?)

@extrawurst
Copy link
Owner Author

extrawurst commented May 10, 2021

@cruessler

I’d like to start working on this. I also think that introducing another tab seems like a good idea.

Any update from your side?

@extrawurst
Copy link
Owner Author

Was going to mention, filtering by tag (so making a "tag-log") with :t is part of the search/filter functionality in #672 (continued from #506). So a popup might be better, but I'd question if it would even be necessary (after the search functionality is added, considering you can filter commits by/for tags). Perhaps just to jump to a commit with a specific tag? (or should that be implemented by holding down a key and pressing down/up to jump down/up tags?)

Searching/Filtering is a different use case to having a dedicated UI to list tags and targeted tag-specific functionality.

@cruessler
Copy link
Contributor

@extrawurst Yes, I'm planning on presenting a first version in the next few days! I would go with a popup and make it similar to the one for branches so that they feel consistent.

cruessler added a commit to cruessler/gitui that referenced this issue May 13, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 19, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 22, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 26, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 27, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 27, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 27, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 27, 2021
cruessler added a commit to cruessler/gitui that referenced this issue May 27, 2021
extrawurst pushed a commit that referenced this issue May 27, 2021
This closes #483.
@extrawurst extrawurst mentioned this issue May 27, 2021
2 tasks
extrawurst pushed a commit that referenced this issue May 27, 2021
This closes #483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants