Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected tab is hardcoded to white and cannot be changed via theme #719

Closed
star-szr opened this issue May 21, 2021 · 1 comment
Closed
Milestone

Comments

@star-szr
Copy link
Contributor

star-szr commented May 21, 2021

Describe the bug
The selected tab is not overrideable via the theme, and in addition it is hardcoded to white since around v0.11.0-rc1.

I recently have been trying a light theme, that's how I noticed this.

I will be submitting a PR to at least remove the hardcoding to white, and if you'd like I can also restore the previous coloring of selected_tab but probably needs discussion.

To Reproduce
Steps to reproduce the behavior:

  1. Change your terminal emulator to a light theme
  2. Launch gitui
  3. Notice the white-on-white

Expected behavior
I would expect the selected tab to at least be neutral colored, or to respect the theme.ron settings.

When editing theme.ron I thought this was controlled by selected_tab, but I tested v0.10.1 and it seems like it's been neutral colored for quite some time (since v0.3.0 when theme overrides were added).

Screenshots

v0.15.0, light and dark with no theme overrides:

0 15 0-light

0 15 0-dark

Context (please complete the following information):

  • OS/Distro + Version: Pop!_OS 20.10
  • GitUI Version: v0.15.0
  • Rust version: Not sure, but probably not relevant in this case. I installed gitui via nixpkgs but I can reproduce the behaviour by building gitui from source.

Additional context

Screenshots from v0.2.6 (before initial color theme support was added)

0 2 6-light

0 2 6-dark

Screenshots from v0.10.1 (before the selected tab was hardcoded to white)

0 10 1-light

0 10 1-dark

@extrawurst
Copy link
Owner

closed via #722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants