Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full commit messages in the log #80

Closed
jugglerchris opened this issue May 20, 2020 · 9 comments
Closed

Show full commit messages in the log #80

jugglerchris opened this issue May 20, 2020 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@jugglerchris
Copy link

Is your feature request related to a problem? Please describe.
In the Log tab, I can see only the start of the log message for each commit, but when browsing the log I am likely to want to read the full message (or indeed view the diff).

Describe the solution you'd like
While browing the log, pressing 'enter' when an entry is highlighted could open up a panel showing more information - principally the commit message, but the diff for that commit would also be very useful.

Describe alternatives you've considered
An alternative could be a view like the main Status tab, with commits instead of files on the left, and a panel with the details on the right, showing the commit highlighted.

Additional context
Add any other context or screenshots about the feature request here.

@extrawurst
Copy link
Owner

Hi @jugglerchris thanks for your interest in gitui - this feature is definitely on my list aswell!

@extrawurst extrawurst added the enhancement New feature or request label May 21, 2020
@guss77
Copy link

guss77 commented May 22, 2020

Just wanted to pipe in with a +1 for this and the request that the info panel will also include the list of changed files.

I'm looking at gitui mainly as a replacement for tig's log view - which I find hard to use due to the non-intuitive key binding (using INS/DEL to scroll?!?). Ideally gitui would not only match tig features by showing the branches in the log (including labels) and the full commit message, file list and diff, but also feature better layout and navigation for all these things, for example:

  • use different view ports for the message, file list and diff
  • Allow the user to navigate the file list and choose which file to show in the diff view.

@extrawurst extrawurst added this to the 0.6.0 milestone Jun 1, 2020
@extrawurst
Copy link
Owner

extrawurst commented Jun 2, 2020

So, my current plan is to tackle this in multiple steps:

  1. allow opening an info pane to the side while scrolling the log to show extended information about a commit
  2. when focusing on the right side of extended information it will open this single commit up in a fullscreen popup with the right side being used to show the file diffs exactly like in the Status-Tab

Step 1. will be done for this issue and look something like this:
image

Step2. will be a followup task but could looks something like this:
image

extrawurst pushed a commit that referenced this issue Jun 2, 2020
@extrawurst
Copy link
Owner

first visual prototype:
Screenflick Movie 25

@extrawurst
Copy link
Owner

now with actual data:
Screenflick Movie 26

@extrawurst
Copy link
Owner

now also with file list:
image

@extrawurst
Copy link
Owner

first part is merged into master. looking forward to feedback. next up is: fullscreen commit details (that's where we can diff each file in the commit)
Screenflick Movie 27

extrawurst pushed a commit that referenced this issue Jun 8, 2020
# Conflicts:
#	src/components/textinput.rs
extrawurst pushed a commit that referenced this issue Jun 9, 2020
# Conflicts:
#	src/components/mod.rs
#	src/components/reset.rs
#	src/components/textinput.rs
@extrawurst
Copy link
Owner

next update: now we can open the details of a single commit in a view similar to the status tab where we can diff every individual file inside a commit from the past:
Screenflick Movie 28

extrawurst pushed a commit that referenced this issue Jun 9, 2020
@extrawurst
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants