feat: add branch name validation on renaming #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainad2222
commented
Feb 20, 2024
There was a problem hiding this comment.
For some reason, test_pre_commit_py is panicking while running make check. I'll debug more and try to fix it
Edit: Issue is because in mac python is not available as /usr/bin/env. We need to be specific about python3. In linux also it shouldn't break by changing it. But let me know if something is breaking because of this
lets not do this as on CI everything works fine. never change a running system
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
Closes extrawurst#2062 --------- Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2062 .
It changes the following:
I followed the checklist:
make checkwithout errors