Allow builds from 'git archive' generated tarballs #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
reviewed
Apr 15, 2024
alerque
force-pushed
the
build-from-archive
branch
from
4d1780c to
cfc2ae9
Compare
|
@alerque please add a changelog entry matching other contributions |
alerque
force-pushed
the
build-from-archive
branch
from
cfc2ae9 to
53cdd8a
Compare
|
thanks for your contribution. note that i will change the env name to |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current release can be build from
git clonesources because runninggit rev-parse HEADat build time works, but it fails to build from an archive tarball such as is generated by GitHub when you download the source link on a release and generated withgit archive.This fixes that by first checking an env var that a user can set by using
export TAR_COMMIT_ID=$(git get-tar-commit-id <package>.tar.gz). It isn't a pancea and requires some intervention, but at least it makes it possible to build without a patch, etc.