Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should check isOverwrite() on prepareLocalizations() as well #92

Closed
ioliva opened this issue Mar 29, 2022 · 1 comment
Closed

Should check isOverwrite() on prepareLocalizations() as well #92

ioliva opened this issue Mar 29, 2022 · 1 comment

Comments

@ioliva
Copy link
Contributor

ioliva commented Mar 29, 2022

This mkdir() causes an error even if isOverwrite() returns true:

mkdir($localizationDir, 0777, true);

That's because isOverwrite() is checked only for the main pass directory, but not for the localizations subdirs. If isOverwrite() is true, the previous localization subdirs should be deleted as well, just before preparing the localizations again.

@eymengunay
Copy link
Owner

Hi @ioliva,

Thank you for pointing this out! Unfortunately I do not actively contribute to this repo however any bugfix/new feature PR's are always welcome.

eymengunay added a commit that referenced this issue Apr 19, 2022
Fix: isOverwrite() not honored while preparing localizations (#92).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants