Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preview of weg was not aligned well #195

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

luriusTM
Copy link
Contributor

Only placement of the position has been calculated based on the configuration value.

@luriusTM luriusTM changed the title The preview of weg was not alligned well The preview of weg was not aligned well Oct 20, 2024
@eythaann eythaann self-requested a review October 21, 2024 01:45
@eythaann
Copy link
Owner

@luriusTM thanks for you fix, this will be merged but first you need to sign the commit in order to be verified.
You can read more about this: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@eythaann
Copy link
Owner

Also try rebasing this PR to sign all the commits and forcing push on your branch, Github doesn't allow me merge it cuz the first commit was not signed.

@luriusTM luriusTM force-pushed the feature/preview_placement_issue branch 2 times, most recently from 4a1d1a3 to 5fd4804 Compare October 22, 2024 15:07
@eythaann eythaann merged commit 667f1a4 into eythaann:master Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants