Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style issue with a behaviour association #279

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

luriusTM
Copy link
Contributor

@luriusTM luriusTM commented Nov 14, 2024

Ok, this will be a bit hard, will make some video to understand it more clearly.

Issue: When you leave weg for a blink, it closes the weg bar in case of HideMode.Always & HideMode.On-Overlap

First: It is currently working.
Side note: because in default style, we have a glitch:
image
In this image it seems when you move to preview, it leaves the weg bar... but in the reality, the preview hops under your mouse:
image

If you have different style, it behaves as I described:

Screen.Recording.2024-11-14.113700.mp4

For this to remain open and correct logic to expand I got to wire in the associated pop-ups in the logic. This behaviour is gone with this.

For better style options I gave a possibility to style the opened item whose associatedPopup is opened.
class: 'opened-associated-view'

Hereby you can style like this (Mosue is on preview item / context menu):
image
image
Pre:
image

The "can" and "should" does not comes together; the styles I did not change for now.

Other change:
Closes the preview items in case of weg item context menu. This is mostly unintended I think:
image

@eythaann
Copy link
Owner

eythaann commented Nov 14, 2024

The code is hard to understand, could you try to refactor or renaming functions and variables please?, or some comments on the function to understand what exactly associated popups means

@luriusTM
Copy link
Contributor Author

luriusTM commented Nov 14, 2024

The code is hard to understand, could you try to refactor or renaming functions and variables please?, or some comments on the function to understand what exactly associated popups means

Tried some comments and renames.

It is a bit hard, but all about responsibility propagation. Context menu reports that it is open. UserApplication reports that, it has opened view. Bar calculates the opened views and block the hide methodology.

One more unintended behaviour removed:

Context menu on preview items and context menu on context menu (from master):

Screen.Recording.2024-11-14.165511.mp4

Bit hard to create a video, for something do not do something... :)
(for preview items I currently just blocked to context menu, but added an empty list because it could have some item, close current and kind of, but this is not targeted to that.)

@luriusTM
Copy link
Contributor Author

renamed the class for consistence: 'associated-view-open'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants