-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: sort all top-level imports (#337)
- basically, general format is: ```ts import x from "external-dep" import y from "./internal-dep" ``` - so external deps, new line, then internal/local deps - with some further sorting within there, like trying to keep Node built-ins (e.g. `path`) at the top half of externals, then core deps like `typescript`, then any other external deps - and similar for internal deps -- core internals at the top half of internals, then any other internal deps - just to keep things consistent between files -- makes the top easier to read through when it's similar between files - also makes it easier for contributors to understand where to put imports, as there's a sorting already there - this is how I generally sort my imports and how I wrote most of the unit test suite's imports as well - there is automation for this that we should probably add once TSLint is replaced here; some previous art: - https://github.com/trivago/prettier-plugin-sort-imports - https://github.com/lydell/eslint-plugin-simple-import-sort/ - Older: - https://github.com/renke/import-sort/tree/master/packages/import-sort-style-module - https://github.com/mcdougal/js-isort - inspired by Python's `isort` ofc
- Loading branch information
Showing
11 changed files
with
35 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters