Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abortOnError enhancement: get *all* errors, *then* abort #168

Open
mreuvers opened this issue Aug 21, 2019 · 4 comments
Open

abortOnError enhancement: get *all* errors, *then* abort #168

mreuvers opened this issue Aug 21, 2019 · 4 comments
Labels
kind: feature New feature or request problem: stale Issue has not been responded to in some time

Comments

@mreuvers
Copy link

mreuvers commented Aug 21, 2019

Hello there,

Currently the option abortOnError: true aborts on the first error it encounters when checking a typescript file. When set to false it doesn't bail out at all (and often succeeds completely, even though typescript reported several semantic errors in multiple files e.g.).

I'd like an in-between option, that checks all typescript files, gathers the errors reported, and if there is any error at all (or more) spits it all out at once at the end - and aborts.

Currently the abortOnError: true is painful to work with with (many) errors in large projects, and not aborting at all, is just wrong here as the resulting rollup bundle will be broken.

Would something like this be possible? Thank you.

@ezolenko ezolenko added the kind: feature New feature or request label Aug 22, 2019
@ezolenko ezolenko self-assigned this Aug 23, 2019
@ezolenko
Copy link
Owner

Yep. Might get messy due to the way rollup detects failure (see continueAfterFirstError branch if you want to test it out).

@mreuvers
Copy link
Author

Thank you! I'll give it a try hopefully later today and let you know how it works for me.

Out of curiousity: I saw you also added an additional flag abortOnWarning, what kind of warnings would it abort on in this case?

@mreuvers
Copy link
Author

It seems to work first test. I'd like to test a bit more coming days if you're not in a rush with it?

@ezolenko
Copy link
Owner

Sure, no rush, I'm yet to do a proper testing on it myself.

@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label May 8, 2022
@agilgur5 agilgur5 changed the title abortOnError enhancement request abortOnError enhancement request: get _all_ errors, _then_ abort May 29, 2022
@agilgur5 agilgur5 changed the title abortOnError enhancement request: get _all_ errors, _then_ abort abortOnError enhancement request: get *all* errors, *then* abort May 29, 2022
@agilgur5 agilgur5 changed the title abortOnError enhancement request: get *all* errors, *then* abort abortOnError enhancement: get *all* errors, *then* abort Jun 14, 2022
@ezolenko ezolenko removed their assignment Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request problem: stale Issue has not been responded to in some time
Projects
None yet
Development

No branches or pull requests

3 participants