fix(test): handle pretty
formatting
#377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The integration tests (#371) and
pretty
default change (#372) got merged simultaneously, so the tests need to be updated to handle the newpretty
defaultmaster
is currently failing CI due to thisDetails
the coloration of the errors is quite different when using
pretty
also TS doesn't specify semantic vs. syntax, that's something
print-diagnostics
doesthis test is more resilient to change as well I suppose since no error codes or colors
Future Work
Add unit tests for both
pretty
and non-pretty
versions of errors; currentlyprint-diagnostics
is one of the few files without unit test coverage