test: add print-diagnostics spec
#405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
kind: internal
agilgur5
force-pushed
the
test-add-print-diagnostics
branch
from
ae58a08 to
db8b4c0
Compare
- test all the different categories and formattings - full unit test coverage now! (except for `index`/`tscache`, which integration tests cover)
agilgur5
force-pushed
the
test-add-print-diagnostics
branch
from
db8b4c0 to
a19829b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is built on top of #404 as it uses thecontextchanges made there. #404 is itself built on top of #397. As such, I've marked this PR as "Draft" until those PRs are merged.Rebased on top and marked as ready for review.
Summary
Adds unit tests for all scenarios of
print-diagnostics.tsDetails
index/tscache, which integration tests cover)parse-tsconfigspec #397 being merged)