Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Limited doctrine/collections to ^1.8 #8

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Mar 2, 2023

Right now our tests on 4.3 are failing with:

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  
!!   // Clearing the cache for the behat environment with debug                     
!!   // true                                                                        
!!  
!!  PHP Fatal error:  Class JMS\JobQueueBundle\Entity\Listener\PersistentRelatedEntitiesCollection 
contains 2 abstract methods and must therefore be declared abstract 
or implement the remaining methods 
(Doctrine\Common\Collections\ReadableCollection::findFirst, 
Doctrine\Common\Collections\ReadableCollection::reduce) in 
/var/www/vendor/ezsystems/job-queue-bundle/JMS/JobQueueBundle/Entity/
Listener/PersistentRelatedEntitiesCollection.php on line 22

Link: https://github.com/ibexa/commerce/actions/runs/4308277557/jobs/7514641798

This is caused by our latest changes to website-skeleton (we don't install doctrine/collections during that phase anymore), which means that doctrine/collections v2 was available for installation.

This package uses the collection dependency (though it was not present in composer.json) and is not compatible with v2.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon requested a review from a team March 2, 2023 10:49
@konradoboza konradoboza requested a review from a team March 2, 2023 10:51
@mnocon mnocon requested a review from a team March 2, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants