Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chromium driver #39

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Add support for Chromium driver #39

merged 2 commits into from
Jul 4, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Jun 21, 2019

JIRA: https://jira.ez.no/browse/EZP-30669

Adding support for Chromium driver in our Docker stack.
Related PR: ezsystems/ezplatform#417

@mnocon mnocon changed the title [WIP] Add support for Chromium driver Add support for Chromium driver Jun 21, 2019
@mnocon mnocon requested review from a team and andrerom June 24, 2019 07:05
@mnocon
Copy link
Member Author

mnocon commented Jun 24, 2019

Travis failure is unrelated, but I'll have a look at it

@mnocon mnocon requested a review from m-tyrala June 24, 2019 07:56
@andrerom
Copy link
Contributor

andrerom commented Jun 24, 2019

hmm, but seems tests are broken by the addition of yarn in 2.5.

Is it this part we need to adjust to use latest-node?

printf "\nBuilding on ez_php:latest, composer will implicit check requirements\n"
docker run -ti --rm \
-e SYMFONY_ENV \
-v $(pwd)/volumes/ezplatform:/var/www \
-v $COMPOSER_HOME:/root/.composer \
ez_php:latest \
bash -c "composer -v && composer create-project --prefer-dist --no-progress --no-interaction ezsystems/ezplatform /var/www $EZ_VERSION"

@andrerom
Copy link
Contributor

As for PHP 5.6 - 7.0 it seems to be issue with packages for Debian jessie, but given 7.1 is also jessie based it might just be temporary glitch:

W: Failed to fetch http://deb.debian.org/debian/dists/jessie-updates/InRelease  Unable to find expected entry 'main/binary-amd64/Packages' in Release file (Wrong sources.list entry or malformed file) 

7.2 failure seems to be temprary, bad gateway trying to download blackfire.

@mnocon
Copy link
Member Author

mnocon commented Jun 24, 2019

About the PHP5.6 images - seems like they've been dropped from https://hub.docker.com/_/php (docker-library/php@e9320fd)

@mnocon
Copy link
Member Author

mnocon commented Jun 24, 2019

The part you linked to looks like a good place to fix 7.x builds, I'll commit a change there to verify

@andrerom
Copy link
Contributor

andrerom commented Jun 24, 2019

About the PHP5.6 images - seems like they've been dropped from https://hub.docker.com/_/php (docker-library/php@e9320fd)

They have stopped building new as it is no longer new releases coming for 5.6, but they existing tags still exists. We can drop it in separate PR, but the issue here is not 5.6 afaik.

@andrerom
Copy link
Contributor

@mnocon for the failures, see here: #38

@mnocon
Copy link
Member Author

mnocon commented Jun 27, 2019

@andrerom thanks, I'll rebase this PR after that one is merged

@mnocon
Copy link
Member Author

mnocon commented Jul 2, 2019

@andrerom please have a look again - I've rebased with latest master.

The build for PHP5.6 was still red, because today new version of redis has become available on PECL, without PHP5.6 support - I'm forcing the install of latest stable that supports PHP5.6 (4.3.0) instead. Versions: https://pecl.php.net/package/redis

Please also have a look at https://github.com/ezsystems/ezplatform/pull/417/files , another PR that uses variables introduced in this one.

@andrerom andrerom merged commit 80b85cc into ezsystems:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants