Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30812: Fixed deprecated use of Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch method #7

Merged
merged 1 commit into from
Aug 8, 2019
Merged

EZP-30812: Fixed deprecated use of Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch method #7

merged 1 commit into from
Aug 8, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 2, 2019

JIRA: https://jira.ez.no/browse/EZP-30812

Description

Fixed the following deprecation message:

Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as first argument is deprecated since Symfony 4.3, pass it second and provide the event object first instead.

by swapping argument order in Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch() method calls.

@adamwojs adamwojs self-assigned this Aug 2, 2019
@lserwatka lserwatka merged commit 6de4b25 into master Aug 8, 2019
@lserwatka lserwatka deleted the ezp_30812 branch August 8, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees

@adamwojs adamwojs

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @alongosz @webhdx @micszo @lserwatka