-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32307: Fixed check version stability #86
EZP-32307: Fixed check version stability #86
Conversation
7cc4877
to
a3e49f1
Compare
src/bundle/SystemInfo/Collector/JsonComposerLockSystemInfoCollector.php
Outdated
Show resolved
Hide resolved
cbd6312
to
9b2c36a
Compare
6664a74
to
3bb8d36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good responsibility separation!
$composerCollectorNotFound = new JsonComposerLockSystemInfoCollector(__DIR__ . '/_fixtures/snafu.lock', __DIR__ . '/_fixtures/composer.json'); | ||
$composerCollectorNotFound = new JsonComposerLockSystemInfoCollector( | ||
$this->composerInstalledVersions, | ||
__DIR__ . '/_fixtures/snafu.lock', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
3bb8d36
to
952f490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on Ibexa oss/content/ezp/commerce stable 3.3@rc with patch.
https://issues.ibexa.co/browse/EZP-32307
This PR provides implemented
VersionStabilityChecker
for displaying valid version stability. SinceIbexa/website-skeleton
(https://github.com/ibexa/website-skeleton/blob/main/composer.json#L6) providesminimum-stability
set todev
all versions are marked as ‘dev
’. Now version stability is based onibexa/oss
version because this package is installed for all Ibexa Platform versions. For BC break reason old check based on composer.lock minimum stability is set as callback in case when Ibexa/oss is not found.