IBX-1999: Added pagination to URL Wildcard tab in URL Management #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Jan 25, 2022
Steveb-p
approved these changes
Jan 25, 2022
Steveb-p
reviewed
Jan 25, 2022
6 tasks
Steveb-p
approved these changes
Jan 25, 2022
konradoboza
approved these changes
Jan 25, 2022
adamwojs
requested changes
Jan 25, 2022
src/bundle/Resources/views/themes/admin/url_wildcard/list.html.twig
Outdated
Show resolved
Hide resolved
| @@ -73,8 +73,8 @@ | |||
| </tr> | |||
| </thead> | |||
| <tbody> | |||
| {% if url_wildcards|length %} | |||
| {% for url_wildcard in url_wildcards %} | |||
| {% if pager.currentPageResults|length %} | |||
There was a problem hiding this comment.
Suggested change
| {% if pager.currentPageResults|length %} | |
| {% if pager|length %} |
Pagerfanta objects are countable. Also you use getNbResults method.
There was a problem hiding this comment.
changed to count is same as(0) like in another tabs in admin-ui
added 3 commits
January 25, 2022 19:20
Steveb-p
approved these changes
Jan 26, 2022
Steveb-p
approved these changes
Jan 26, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
adamwojs
approved these changes
Jan 26, 2022
Steveb-p
approved these changes
Jan 26, 2022
bogusez
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)