IBX-2000: Added search into URL Wildcard tab #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2022
adamwojs
requested changes
May 20, 2022
src/bundle/Resources/views/themes/admin/url_wildcard/list.html.twig
Outdated
Show resolved
Hide resolved
mikadamczyk
reviewed
May 24, 2022
Steveb-p
reviewed
May 24, 2022
|
Some of the comment are still is not addressed: #2042 (comment) |
@adamwojs now should be done |
adamwojs
approved these changes
May 24, 2022
ViniTou
reviewed
May 24, 2022
Steveb-p
approved these changes
May 24, 2022
webhdx
suggested changes
May 24, 2022
src/bundle/Resources/views/themes/admin/url_wildcard/list.html.twig
Outdated
Show resolved
Hide resolved
webhdx
approved these changes
May 24, 2022
dew326
requested changes
May 25, 2022
src/bundle/Resources/views/themes/admin/url_wildcard/list.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/translations/ezplatform_url_wildcard.en.xliff
Outdated
Show resolved
Hide resolved
src/bundle/Resources/translations/ezplatform_url_wildcard.en.xliff
Outdated
Show resolved
Hide resolved
lucasOsti
approved these changes
May 25, 2022
dew326
requested changes
May 25, 2022
src/bundle/Resources/views/themes/admin/url_wildcard/list.html.twig
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
ViniTou
approved these changes
May 25, 2022
tomaszszopinski
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ezsystems/ezplatform-kernel#301
regression tests passed:
ibexa/commerce#88
ibexa/experience#39
Checklist:
$ composer fix-cs)