Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6276: Added removing content type draft when clicking cancel button #2107

Merged

Conversation

ciastektk
Copy link
Contributor

Question Answer
Tickets IBX-6276
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR adds removing content type draft when clicking "Discard changes" button in create content type process. There is inconsistency between create and update actions. In edit process clicking "Discard changes" button removes draft but not in create process.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 3.3.34-dev.

Discussed architecture limitations internally. 🙈

@micszo micszo removed their assignment Aug 3, 2023
@ciastektk ciastektk merged commit 53d5680 into 2.3 Aug 3, 2023
14 checks passed
@ciastektk ciastektk deleted the ibx-6276-added-removing-draft-when-clicking-cancel-button branch August 3, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants