Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2942: Added missing edit permission restrictions in UDW response #2109

Merged
merged 1 commit into from
Sep 4, 2023
Merged

IBX-2942: Added missing edit permission restrictions in UDW response #2109

merged 1 commit into from
Sep 4, 2023

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Aug 28, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2942
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR does not fix bug described in IBX-2942 but only provides backend part to this fix.
Permission restrictions for content edit were missing in UDW response. This data are needed to limit access to content edit.

Screen Shot 2023-08-28 at 09 34 32

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ciastektk ciastektk changed the title IBX-2942: Added missing edit permission restriction in UDW response IBX-2942: Added missing edit permission restrictions in UDW response Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ciastektk ciastektk requested a review from a team August 28, 2023 07:29
@micszo micszo self-assigned this Sep 4, 2023
@micszo micszo mentioned this pull request Sep 4, 2023
Closed
micszo
micszo approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that UDW response for edit now also contains selected restricted content type ids and restricted language codes.

Sanities OK.

QA Approved on Ibexa Commerce 3.3.35-dev.

@micszo micszo removed their assignment Sep 4, 2023
@ciastektk ciastektk merged commit 118c25f into 2.3 Sep 4, 2023
22 checks passed
@ciastektk ciastektk deleted the ibx-2942-added-missing-permission-restrictions branch September 4, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ciastektk @Steveb-p @micszo @konradoboza @mikadamczyk @Nattfarinn @ViniTou