Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6644: Gracefully handle broken custom URL aliases #2111

Merged
merged 3 commits into from
Oct 5, 2023
Merged

IBX-6644: Gracefully handle broken custom URL aliases #2111

merged 3 commits into from
Oct 5, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Oct 2, 2023

Question Answer
Tickets IBX-6644
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Try/catch was added with logging.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team October 2, 2023 12:31
@barw4 barw4 self-assigned this Oct 2, 2023
@barw4 barw4 requested review from Steveb-p and a team October 2, 2023 14:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team October 4, 2023 07:49
@konradoboza konradoboza requested a review from a team October 4, 2023 07:52
tomaszszopinski
tomaszszopinski approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@ViniTou ViniTou merged commit f721921 into 2.3 Oct 5, 2023
14 checks passed
@ViniTou ViniTou deleted the ibx-6644-grace-handle-broken-aliases branch October 5, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @Steveb-p @ViniTou @konradoboza @tomaszszopinski @mikadamczyk @Nattfarinn @ciastektk @dew326