IBX-8350: Text line fields which is not marked as required, but has a minimum length constraint set, is basically treated as required in JS validation #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minimum length constraint set, is basically treated as required
|
dew326
approved these changes
Jun 6, 2024
lucasOsti
approved these changes
Jun 12, 2024
GrabowskiM
approved these changes
Jun 12, 2024
tischsoic
approved these changes
Jun 12, 2024
|
@vidarl Please change the branch name to something more concise and do not use comma (dash and underscore characters are fine). It doesn't play well with composer and CI scripts. |
bogusez
approved these changes
Jul 2, 2024
|
Right, I didn't notice the comma in the branch name.. Will rename branch. That means PR will be closed though |
vidarl
deleted the
IBX-8350_Text_line_fields_which_is_not_marked_as_required,_but_has_a_minimum_length_constraint_set_is_basically_treated_as_required
branch
2 tasks
|
New PR : #2122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When input is checked for length constrains in JS, it is not taken into account whatever the field is empty or not. ( As long as the field is not required, it is okay that the value is empty even if it has a constrain on minimum characters )
Checklist:
$ composer fix-cs)