Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1063: Fixed VersionValidator #235

Merged
merged 1 commit into from
Oct 11, 2021
Merged

IBX-1063: Fixed VersionValidator #235

merged 1 commit into from
Oct 11, 2021

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Sep 17, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-1063
Type bug
Target Ibexa version v3.3
BC breaks no

This seems an obvious bug because identifier is used even at https://github.com/ezsystems/ezplatform-kernel/blob/master/eZ/Publish/Core/Repository/Validator/VersionValidator.php#L79.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@SerheyDolgushev SerheyDolgushev mentioned this pull request Sep 17, 2021
Merged
@SerheyDolgushev
Copy link
Contributor Author

@ezsystems/engineering-team

@micszo micszo self-assigned this Sep 24, 2021
@Steveb-p Steveb-p requested a review from a team October 6, 2021 09:31
@alongosz alongosz added Bug Something isn't working Ready for QA labels Oct 6, 2021
@micszo
Copy link
Member

micszo commented Oct 8, 2021

Hi @SerheyDolgushev
could you try rebasing both PRs?
It's not possible to reload cache:
Invalid constructor argument 5 for service "Ibexa\Platform\Personalization\Cache\CachedRecommendationPerformanceService": argument 4 must be defined before. Check your service definition.

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SerheyDolgushev
Copy link
Contributor Author

Hello @micszo
I rebased #235 and ezsystems/ezplatform-content-forms#49.
Please let me know if anything else is required from me.

micszo
micszo approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML validation is now correctly triggered on "Approved by legal" step when required attribute is missing in custom tag.
Tested on Ibexa Experience 3.3.9-dev with branches.
Sanities verified with regression suite.

@micszo micszo removed their assignment Oct 11, 2021
@alongosz alongosz merged commit 601c8eb into ezsystems:1.3 Oct 11, 2021
@alongosz
Copy link
Member

Thank you @SerheyDolgushev 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SerheyDolgushev @micszo @alongosz @Steveb-p @webhdx