Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3595: Fixed processing timestamps in ibexa:timestamps:to-utc command #342

Merged
merged 1 commit into from
Oct 18, 2022
Merged

IBX-3595: Fixed processing timestamps in ibexa:timestamps:to-utc command #342

merged 1 commit into from
Oct 18, 2022

Conversation

damianz5
Copy link
Contributor

Question Answer
JIRA issue IBX-3595
Type bug
Target Ibexa version v3.3
BC breaks no

Date Field shows -1D after update to v3.3.15+ (from v3.3.14)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

alongosz
alongosz approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damianz5 failed CI jobs need to be restarted

@alongosz alongosz changed the title IBX-3595: Date Field shows -1D issue IBX-3595: Fixed processing timestamps in ibexa:timestamps:to-utc command Oct 12, 2022
@alongosz
Copy link
Member

alongosz commented Oct 12, 2022 •
edited
Loading

@damianz5 commit message needs to be adjusted in the same way PR title got. The format is: IBX-XXXX: <essence of changes in past simple>

@damianz5 damianz5 force-pushed the IBX-3595-date-field-minus-1-day-issue branch from 1bb5c0f to 5247f9b Compare October 13, 2022 08:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz added Bug Something isn't working Ready for QA labels Oct 14, 2022
@bogusez bogusez self-assigned this Oct 18, 2022
@bogusez bogusez added QA approved Ready for MERGE To be set by author or maintainer and removed Ready for QA labels Oct 18, 2022
@adamwojs adamwojs merged commit 6019e73 into 1.3 Oct 18, 2022
@adamwojs adamwojs deleted the IBX-3595-date-field-minus-1-day-issue branch October 18, 2022 11:11
@adamwojs
Copy link
Member

Could you please merge up changes?

@alongosz alongosz mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@bogusez bogusez bogusez approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@bogusez bogusez

Labels
Bug Something isn't working QA approved Ready for MERGE To be set by author or maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@damianz5 @alongosz @adamwojs @ViniTou @bogusez @mikadamczyk @Steveb-p @ciastektk