Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5388: Added index on contentclassattribute_id in the ezcontentobject_link table #378

Merged
merged 1 commit into from
Jul 24, 2023
Merged

IBX-5388: Added index on contentclassattribute_id in the ezcontentobject_link table #378

merged 1 commit into from
Jul 24, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jul 20, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-5388
Type improvement
Target Ibexa version v3.3
BC breaks no

This change is meant to improve performance when performing multiple deletes on the ezcontentobject_link table.
Charts/screenshots of performance upgrades are available in the public ticket.

Related PR: https://github.com/ibexa/installer/pull/114

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Improvement Changes not fixing or changing behavior Ready for review Doc needed The changes require some documentation labels Jul 20, 2023
@barw4 barw4 self-assigned this Jul 20, 2023
@Steveb-p
Copy link
Contributor

Charts/screenshots of performance upgrades are available in the public ticket.

Out of curiosity I went looking for those. Where are they exactly...?

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@barw4
Copy link
Member Author

barw4 commented Jul 20, 2023

@Steveb-p you should be able to see it now

@barw4 barw4 requested a review from a team July 20, 2023 11:59
tomaszszopinski
tomaszszopinski approved these changes Jul 24, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP content 3.3

@alongosz alongosz merged commit 4e8b123 into 1.3 Jul 24, 2023
25 checks passed
@alongosz alongosz deleted the ibx-5388-add-index-ezcontentobject_link branch July 24, 2023 11:31
@alongosz alongosz mentioned this pull request Jul 24, 2023
Merged
@MagdalenaZuba MagdalenaZuba removed the Doc needed The changes require some documentation label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@barw4 barw4

Labels
Improvement Changes not fixing or changing behavior QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @Steveb-p @adamwojs @konradoboza @tomaszszopinski @kisztof @mikadamczyk @alongosz @MagdalenaZuba