IBX-4031: Forced copy non-translatable field values from main content to current draft during publish #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Nattfarinn
approved these changes
Aug 4, 2023
ViniTou
approved these changes
Aug 4, 2023
|
It seems that for some reason, maybe totally unrelated, integration tests are failing at random here. Could you check if those changes could introduce that behavior? Also, not sure, but maybe it is reasonable to move that new integration test into new integration setup based on TestKernel? @alongosz |
alongosz
reviewed
Aug 4, 2023
… to current draft during publish
… to current draft during publish
barw4
force-pushed
the
ibx-4031-update-non-translatable-fields-during-publish
branch
from
cd1cf68
to
d49629a
Compare
alongosz
reviewed
Aug 7, 2023
...gration/Core/Repository/ContentService/CopyNonTranslatableFieldsFromPublishedVersionTest.php
Show resolved
Hide resolved
...gration/Core/Repository/ContentService/CopyNonTranslatableFieldsFromPublishedVersionTest.php
Outdated
Show resolved
Hide resolved
alongosz
reviewed
Aug 7, 2023
...gration/Core/Repository/ContentService/CopyNonTranslatableFieldsFromPublishedVersionTest.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Aug 7, 2023
konradoboza
approved these changes
Aug 7, 2023
...gration/Core/Repository/ContentService/CopyNonTranslatableFieldsFromPublishedVersionTest.php
Outdated
Show resolved
Hide resolved
kisztof
approved these changes
Aug 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Regression tests passed: |
bogusez
approved these changes
Aug 10, 2023
bogusez
added
QA approved
Ready for MERGE
alongosz
deleted the
ibx-4031-update-non-translatable-fields-during-publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3Following PR assures that a content that is being published will have updated values for its non-translatable fields taken from main published version.
Related PR: ezsystems/ezplatform-content-forms#71
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).