IBX-7809: Fixed passing locationId instead of contentId when creating UserMetadata criterion from UserGroupLimitationType level

[konradoboza]

Question	Answer
JIRA issue	IBX-7809
Type	bug
Target Ibexa version	v3.3, 4.5, 4.6
BC breaks	no

Apparently, UserGroupLimitationType contains a wrong usage of UserMetadata criterion - it works with content ids whereas ids of parent locations were passed. That resulted in empty subitems list when Content Type Group: Self limitation was put in place - it basically converts to the mentioned criterion but simply populates wrong parameters.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[konradoboza]

Discussing best way to add test coverage.

[konradoboza]

Added test case covering the scenario described in the JIRA ticket (it fails without introducing the actual fix).

[alongosz]

Note: CI is failing.

[konradoboza]

Yeah, apparently Solr (and probably Elastic)-related changes are needed too. simple reindex did the trick. At least added test seems to do the job. ;)

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[tomaszszopinski]

QA approved on IbexaDXP on 3.3 oss & content (ES)