Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6239: Added Content Type for Image Variation #105

Merged
merged 3 commits into from
Sep 20, 2023
Merged

IBX-6239: Added Content Type for Image Variation #105

merged 3 commits into from
Sep 20, 2023

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Aug 30, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6239
Type bug
Target version v3.3
BC breaks no
Tests pass yes
Doc needed no

Summary

This PR updates the Content-Type header in the image variation endpoint(/api/ezp/v2/content/binary/images/270-999-1/variations/medium) and adds an integration test for it.

Changes

  • Content-Type Header: Updated from text/html to application/vnd.ez.api.ContentImageVariation+xml.
  • New Test: Added an integration test for the ImageVariation endpoint.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@kisztof kisztof force-pushed the bugfix/IBX-6239-wrong-content-type-for-binary-rest branch 2 times, most recently from f3fef9c to fd50113 Compare August 30, 2023 11:38
@kisztof kisztof requested a review from a team August 30, 2023 11:43
@kisztof kisztof marked this pull request as ready for review August 30, 2023 11:45
@kisztof kisztof force-pushed the bugfix/IBX-6239-wrong-content-type-for-binary-rest branch 2 times, most recently from 9ae64cd to b31331c Compare August 30, 2023 12:07
@kisztof kisztof force-pushed the bugfix/IBX-6239-wrong-content-type-for-binary-rest branch from b31331c to 261cced Compare August 30, 2023 12:46
alongosz
alongosz reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kisztof almost ok 💪
see the review and also Steve's comments.

src/lib/Server/Output/ValueObjectVisitor/ImageVariation.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
tests/bundle/Functional/ImageVariationTest.php Outdated Show resolved Hide resolved
webhdx
webhdx suggested changes Sep 12, 2023
View reviewed changes
tests/bundle/Functional/TestCase.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx requested a review from a team September 13, 2023 07:57
@mikadamczyk mikadamczyk requested a review from a team September 13, 2023 08:01
@Steveb-p Steveb-p merged commit 4c8a173 into 1.3 Sep 20, 2023
13 checks passed
@Steveb-p Steveb-p deleted the bugfix/IBX-6239-wrong-content-type-for-binary-rest branch September 20, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kisztof @mikadamczyk @Steveb-p @alongosz @ciastektk @webhdx @konradoboza @katarzynazawada @ViniTou