IBX-4123: [Backport] Added /languages and /languages/{code} endpoints
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
…ints (cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
konradoboza
approved these changes
Nov 9, 2023
ciastektk
approved these changes
Nov 9, 2023
kisztof
approved these changes
Nov 9, 2023
alongosz
reviewed
Nov 9, 2023
Comment on lines
9
to
17
| namespace EzSystems\EzPlatformRest\Server\Controller; | ||
|
|
||
| use eZ\Publish\API\Repository\LanguageService; | ||
| use eZ\Publish\API\Repository\Values\Content\Language as ApiLanguage; | ||
| use EzSystems\EzPlatformRest\Server\Controller as RestController; | ||
| use EzSystems\EzPlatformRest\Server\Values\LanguageList; | ||
| use Traversable; | ||
|
|
||
| final class Language extends RestController |
There was a problem hiding this comment.
legacy namespaces for new classes are technically not allowed after rebranding due to BC policy. I see 2 options here:
either use Ibexa namespace or make the class internal so we don't have to keep BC (we don't do it for controller classes anyway, but at least it would be more clear that way).
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Nov 22, 2023
mnocon
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3.0Warning
When merging up, do not apply those changes. They already exist downstream.
Needed due to dependency in Ibexa Connect, as part of Content creation and other modules.
(cherry picked from commit 674e612e176bc85556513a716556d643f81d722d)
TODO:
$ composer fix-cs).