-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3814: Added new endpoint to get field definition by identifier #99
Conversation
src/lib/Server/Output/ValueObjectVisitor/RestFieldDefinition.php
Outdated
Show resolved
Hide resolved
tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
Outdated
Show resolved
Hide resolved
src/lib/Server/Output/ValueObjectVisitor/RestFieldDefinition.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that a functional test (integration actually) is missing.
See tests in tests/bundle/Functional
. There should be at least one well-known field definition that we can query against an actual instance of Ibexa DXP and check the result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You can take a look at ibexa/rest#40 regarding how I envision we will write tests in the newer packages. I'm talking specifically about REST response snapshots.
tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but please update REST reference as well
Regression tests passed: |
For the purpose of the multi-upload functionality in BO, an endpoint for getting field def has been added by the identifier (in admin-UI we use the identifier of the field to define which field will be used to upload the file).
TODO:
$ composer fix-cs
).