Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8019: Replaced LocationService::loadLocationChildren usages with SearchService::findLocations #114

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jun 2, 2024

Question Answer
JIRA issue IBX-8019
Type improvement
Target Ibexa DXP version v3.3
BC breaks no
Doc needed no

Replaced usage of LocationService::loadLocationChildren in favor of SearchService::findLocations which operates much faster.

I wanted to keep changes as concise as possible, however found out that affected tests LocationEventSubscriber and TrashEventSubscriber did not checked run any checks against calling EventNotificationService::sendNotification which is what is the most important part of the subscribers.

Related PRs:

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@konradoboza konradoboza requested a review from a team June 3, 2024 06:15
@Nattfarinn Nattfarinn requested a review from a team June 3, 2024 06:32
@webhdx
Copy link
Contributor Author

webhdx commented Jun 3, 2024

@konradoboza Fixed

@webhdx webhdx requested a review from konradoboza June 3, 2024 06:44
@konradoboza konradoboza requested a review from a team June 3, 2024 06:45
@ciastektk
Copy link
Contributor

@webhdx, CI is red

@webhdx
Copy link
Contributor Author

webhdx commented Jun 3, 2024

@ciastektk Fixed, forgot to push updated PHPStan baseline 🤦

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP exp 3.3.37.

@ciastektk ciastektk merged commit 2516953 into 2.1 Jun 7, 2024
7 checks passed
@ciastektk ciastektk deleted the IBX-8019_Load_location_chidren branch June 7, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants