Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutOfMemoryError/memory leak on e.<number> input #374

Closed
Maxr1998 opened this issue Apr 1, 2023 · 1 comment · Fixed by #385
Closed

OutOfMemoryError/memory leak on e.<number> input #374

Maxr1998 opened this issue Apr 1, 2023 · 1 comment · Fixed by #385
Labels
bug

Comments

@Maxr1998
Copy link

Maxr1998 commented Apr 1, 2023

Running the following code causes my Android app the memory usage to rise rapidly until it is interrupted or crashes.

val ex = Expression("e.1")
ex.evaluate()

It's reproducible on both 3.0.4 and 3.0.3, I haven't checked any other versions. In the debugger I noticed that the Tokenizer.tokens list is seemingly the culprit, containing thousands of NUMBER_LITERAL entries with value set to an empty string.
@uklimaschewski
Copy link
Collaborator

Hi, I would expect this to produce a parsing error before trying to evaluate.

uklimaschewski added a commit that referenced this issue May 29, 2023
@uklimaschewski
fixes OutOfMemoryError/memory leak on e.<number> input #374
a9d8c26
@uklimaschewski uklimaschewski linked a pull request May 29, 2023 that will close this issue
fixes OutOfMemoryError/memory leak on e.<number> input #374 #385
Merged
@uklimaschewski uklimaschewski mentioned this issue Jun 4, 2023
Merged
uklimaschewski added a commit that referenced this issue Jun 8, 2023
@uklimaschewski
fixes OutOfMemoryError/memory leak on e.<number> input #374 (#385)
7c39c54 
* fixes OutOfMemoryError/memory leak on e.<number> input #374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes OutOfMemoryError/memory leak on e.<number> input #374 ezylang/EvalEx
2 participants
@uklimaschewski @Maxr1998