Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds single quote string literal #416

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Conversation

Snownee
Copy link
Contributor

@Snownee Snownee commented Dec 19, 2023

This PR adds support for declaring a string literal using single quotes. This feature is disabled by default.

Related discussion: #383

@Snownee Snownee changed the base branch from main to 3.1.x December 20, 2023 14:55
Copy link
Collaborator

@uklimaschewski uklimaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yo very much, good idea in general.
But before I can merge his, please:

  • Check and fix my code comments
  • Extend the corresponding documentation with information on how to use string literals (chapters configuration and the STRING data type description).

@Snownee Snownee changed the base branch from 3.1.x to main December 22, 2023 09:41
docs/configuration/configuration.md Outdated Show resolved Hide resolved
docs/configuration/configuration.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@uklimaschewski uklimaschewski merged commit f9b78b9 into ezylang:main Dec 23, 2023
2 checks passed
@uklimaschewski
Copy link
Collaborator

Thank you, I added some more clarification to the configuration documentation.

@Snownee Snownee deleted the 3.1.x branch December 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants