#435 Fix zero with scale to boolean (main)

[stevenylai]

Fixes #435 in the main branch

[Adler95]

@stevenylai I don't think this is the appropriate fix, as it doesn't really solve the: #435.
The problem must be somewhere in the evaluation process since EvaluationValue already contains incorrect result.

[stevenylai]

It's a follow-up for #417 where the fix is to replace .equals() with .compareTo(). We missed the int -> boolean conversion part from the previous fix.

[Adler95]

All good. I agree with you that there is a necessity to replace .equals() with .compareTo(). I just wanted to point out that it doesn't fix the issues referenced in your PR comment. #435 :)

[stevenylai]

But I have a test 0.0&&1 : false under InfixAndOperatorTest which fails until I applied the change. Isn't this verifying the correct behavior as you described in the issue? Or perhaps you think this test is not enough to replicate the issue?

[Adler95]

@stevenylai I just did a bit more detailed review of the process (at first I thought that this method is not invoked during evaluation). I can see now that this is the proper fix. I apologize for the false information and thank you for providing the fix quickly. :)

[uklimaschewski]

Thanks, you were a little bit faster than me.
I have just one request: Can you not do the cast directly, but use the getNumberValue() method, instead?

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud