EvaluationValue optimization

[oswaldobapvicjr]

This PR optimizes the existing method EvaluationValue.nullValue() to return a shared, pre-built EvaluationValue instance (and not create a new object at each call).

Since it's an immutable object, it is safe to reuse the same instance without issues (similar to Collections.emptyList(), or BigDecimal.ZERO, for example).

By reusing the same object, we avoid GC overhead.

[melontini]

I think booleans should be constant too, since they are only 2 possible states.

[oswaldobapvicjr]

I found something strange in the constructor EvaluationValue(Object, ExpressionConfiguration) too:

  public EvaluationValue(Object value, ExpressionConfiguration configuration) {

    EvaluationValue converted =
        configuration.getEvaluationValueConverter().convertObject(value, configuration);

    this.value = converted.getValue();
    this.dataType = converted.getDataType();
  }

Here, the converted is already an EvaluationValue, why duplicate it into another object?
Can we act on it too, @uklimaschewski ?

A simple proposal could be to deprecate this constructor and replace it with a factory method, for convenience:

  public static EvaluationValue of(Object value, ExpressionConfiguration configuration) {
    return configuration.getEvaluationValueConverter().convertObject(value, configuration);
  }

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[uklimaschewski]

Thank you very much