[#21] TestContainer 적용 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TestContainer 적용
- Redis 자료구조 변경 (Strings > Sets)
- key 값 변경 ("event:{eventId}:date:{eventDate}:member:{memberId}" > "{eventId}:{eventDate}")
- 브로커 1개 > 3개 변경
- aladiin.couponapi.model.dto > aladiin.core.dto
f-lab-lyan
reviewed
Sep 16, 2024
admin-api/src/test/java/aladiin/adminapi/config/RedisConfiguration.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Sep 16, 2024
| public boolean findMember(String key) { | ||
| return redissonClient.getBucket(key).isExists(); | ||
| public boolean findMember(String key, Long value) { | ||
| return redissonClient.getSet(key).contains(value); |
There was a problem hiding this comment.
Suggested change
| return redissonClient.getSet(key).contains(value); | |
| return redissonClient.exists(key + '{' + value + '}'); |
- Redis 자료구조 변경 (Sets > Strings)
- key 값 변경 ("{eventId}:{eventDate}" > "{eventId}:{eventDate}:{memberId}")
- aladiin.couponapi.model.dto.EventJoinRequest > aladiin.core.request.EventJoinRequest; - com.aladiin.couponconsumer > aladiin.couponconsumer
f-lab-lyan
reviewed
Sep 23, 2024
| // 3. 쿠폰 발급 | ||
| // ㄴ 메모리 쿠폰 재고 감소 | ||
| // ㄴ RDB 쿠폰 발급 처리 | ||
| couponService.issue(eventJoinRequest.getMemberId()); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#21] TestContainer 적용