[#6] 싱글모듈>멀티모듈 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- module-web 제거
- readme 수정
- readme 수정
f-lab-lyan
reviewed
Apr 14, 2024
| //어플리케이션 실행에 필요한 모든 의존성을 포함하지 않고 클래스파일과 리소스 파일만 포함 | ||
| //web 모듈을 추가하면서 bootJar를 사용하지 않는다. | ||
| tasks.jar { enabled = true } | ||
| tasks.bootJar { enabled = false } |
There was a problem hiding this comment.
이 설정을 넣어야하는거라면, springboot plugin을 빼는게 더 좋지 않을까요?
f-lab-lyan
reviewed
Apr 14, 2024
There was a problem hiding this comment.
아무내용도 없으면 지우는 게 더 좋지 않을까 싶습니다.
|
지금 보면, 모듈이 세 개가 있는데, 각각의 모듈의 역할에 대해서 정리(?)하고 넘어가면 좋을 것 같습니다. 아울러, 세 개가 모두 필요한지도 한번 고민해보시면 좋을 것 같네요. |
|
그리고 controller의 테스트 코드가 빠진 것 같네요. 추가 부탁 드립니다. |
f-lab-lyan
approved these changes
Apr 15, 2024
# Conflicts: # build.gradle # src/main/java/com/hello/cosmetics/main/MainController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6